sap_general_preconfigure: skip var-naming[no-role-prefix] #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... for the three variables sap_hostname, sap_domain, sap_ip. Those are used in many places in the role and the effort for changing and testing the code is too high given that we plan to replace this part of the role by the new role sap_maintain_etc_hosts. Relates to sap-linuxlab#589. Signed-off-by: Bernd Finger <bfinger@redhat.com>
ja9fuchs
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for the three variables sap_hostname, sap_domain, sap_ip.
Those are used in many places in the role and the effort for changing and testing the code is too high given that we plan to replace this part of the role by the new role sap_maintain_etc_hosts.
Relates to #589.