sap_general_preconfigure, sap_maintain_etc_hosts: Ignore comments #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in column 1 of /etc/hosts lines. Solves issue sap-linuxlab#132. Signed-off-by: Bernd Finger <bfinger@redhat.com>
ja9fuchs
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
👍
Tested on RHEL.
Verified:
- duplicate but commented entries are ignored by both roles with the PR code, while both fail independent from each other when using the current
devcode - the preconfigure role still fails correctly when there is a commented entry but no active one
marcelmamula
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
LGTM, it works but it still looks disheveled because of #881
# 10.1.1.1 testnode.suse.com testnode
# 10.1.1.1 testnode.suse.com testnode
10.1.1.1 testnode.suse.com testnode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in column 1 of /etc/hosts lines.
Solves issue #132.