Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_swpm: removed duplicates from credentials_hana section #982

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

SunnyCrockett
Copy link

The lines for HDB_Schema_Check_Dialogs.schemaPassword and storageBasedCopy.hdb.systemPassword were within the credentials_hana section and again directly below it. I removed the duplicate outside the section.

@sean-freeman sean-freeman changed the title Removed duplicates from credentials_hana section sap_swpm: removed duplicates from credentials_hana section Feb 19, 2025
@sean-freeman
Copy link
Member

Also, there is a duplicated block on the next line after this:

{% if 'credentials_anydb_ibmdb2' in sap_swpm_inifile_sections_list %}

###################################################################
# BEGIN section credentials_anydb_ibmdb2                          #
#                                                                 #
nwUsers.db6.db2sidPassword = {{ sap_swpm_sap_sidadm_password }}
# nwUsers.db6.db2sidUid =
#                                                                 #
#  END  section credentials_anydb_ibmdb2                          #
###################################################################
{% endif %}

Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@berndfinger berndfinger merged commit 3466a46 into sap-linuxlab:dev Feb 28, 2025
4 checks passed
berndfinger added a commit to berndfinger/community.sap_install that referenced this pull request Feb 28, 2025
... from templates/inifile_params.j2

Solves sap-linuxlab#985. See also PR sap-linuxlab#982.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants