sap_*_preconfigure/Suse: Enhance saptune revert logic #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #930 has introduced new way of handling
saptuneworkflow, but it has shown new edge case where:sap_general_preconfiguresaptune applies sap note2578899sap_hana_preconfigure: saptune applies solution HANA which already contains2578899sap_hana_preconfigure: saptune verification of solution HANA fails, because: Application of solution skipped note2578899, which was older version, resulting in return code 1 in verification.It is recommended to always revert saptune before applying solutions and this PR is handling that.
Test Results
This issue appeared on Cloud PAYG instances and this PR was tested on AWS and AZ with SLES4SAP 15 SP6, which had issue before.