Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Big IP exceptions metrics, fix logging add retries for sync RouteDomain. #281

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

velp
Copy link
Contributor

@velp velp commented Dec 10, 2024

This PR adds several fixes for l2_sync problems:

  1. Fixes for attribute error in response logging handler:
    ERROR octavia_f5.controller.worker.controller_worker AttributeError: 'Response' object has no attribute 'txt'
    
  2. Adds retries for EnsureRouteDomain task to avoid situation when route domain was not configured in first attempt
  3. Adds several metrics for low-level Big IP REST client to monitor exceptions in l2_sync flows and to be able to see exact number of failed requests.

Related to issue: https://github.wdf.sap.corp/cc/octavia-issues/issues/39

Copy link
Contributor

@m-kratochvil m-kratochvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for following up on this topic, Vadim!

Copy link
Collaborator

@BenjaminLudwigSAP BenjaminLudwigSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@velp velp merged commit ceb09b7 into stable/yoga-m3 Dec 11, 2024
3 checks passed
@BenjaminLudwigSAP BenjaminLudwigSAP deleted the add_metrics_and_fix_logs branch December 11, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants