Rescheduling: Always set availability zone to target host #282
+27
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminLudwigSAP
force-pushed
the
rescheduling-az
branch
from
ac272e2 to
a30009b
Compare
|
The force push was to retrigger the Python Package workflow, because I believed the error to be temporary. |
m-kratochvil
approved these changes
Jan 21, 2025
|
Merged stable/yoga-m3 for build workflow fix. |
notandy
requested changes
Jan 21, 2025
Don't log the current LB's AZ, since that would be one additional DB query, and the new AZ has already been logged by the execute method.
notandy
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a LB DB entry is rewritten after it has been rescheduled, it can be considered expected behavior to also adjust the availability zone.
Tested in QA with both cases; Rescheduling to an AZ-aware device and rescheduling away from an AZ-aware device.