-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:export complex nested values as a metric #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally some real code review again, I like it!
Added some refinements and would like to avoid the use of the internal data structure of GaugeMetricFamily.
Co-authored-by: Tommy Sauer <tommy.sauer@sap.com>
Co-authored-by: Tommy Sauer <tommy.sauer@sap.com>
Co-authored-by: Tommy Sauer <tommy.sauer@sap.com>
Co-authored-by: Tommy Sauer <tommy.sauer@sap.com>
Co-authored-by: Tommy Sauer <tommy.sauer@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, let's go!
Testing for this is still on the old branch, that's why it is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Great job on this! |
There are metric keys at the vrops API that return complex data types. In most cases, they contain valuable information that only makes sense when mapped to several dedicated metrics.
Here is an attempt to implement it as generic as possible. If there is a known key with a complex data structure for a collector, then this case must be implemented specifically. Several keys per collector are possible.
Internal vm names are mapped to the name.
Input:
Output: