-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPD-417: add scanner and get resources from tokens #28
Conversation
@hailihu I had to do some code duplication and making a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great new functionality! I suggest to generalize scripts instead of duplicating them, and move example to general examples
folder.
Co-authored-by: Haili Hu <hailihu@gmail.com>
The requested changes have been implemented, unfortunately, GH made them "outdated" when I moved files around. So I cant confirm the changes have been done. Anyway, they have been done. |
Great work! Some minor comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
(let's see if this submission changes the state if the PR, its not clear to me)
What has been done? I don't see a new commit. |
I approved the old 'outdated' changes, but this didnt do anything. I can't see the latest change request. |
Sorry, I didn't submit the review yet, done now. |
This merge will add the ability to scan a token for
In this way a user can "just scan for tokens and start a client" if needed, and extend to multiple clients based on resource requirements in the tokens.