Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPD-417: add scanner and get resources from tokens #28

Merged
merged 29 commits into from
Jan 14, 2025
Merged

SPD-417: add scanner and get resources from tokens #28

merged 29 commits into from
Jan 14, 2025

Conversation

lnauta
Copy link
Member

@lnauta lnauta commented Nov 12, 2024

This merge will add the ability to scan a token for

  1. Availability: Is there a token in a view?
  2. Add resource-dependent clients: start a client based on information in a token

In this way a user can "just scan for tokens and start a client" if needed, and extend to multiple clients based on resource requirements in the tokens.

@lnauta lnauta requested a review from hailihu November 12, 2024 13:40
@lnauta
Copy link
Member Author

lnauta commented Nov 12, 2024

@hailihu I had to do some code duplication and making a setup.sh for the env, and I don't like either. If you have suggestions to improve this, please let me know.

Copy link
Collaborator

@hailihu hailihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great new functionality! I suggest to generalize scripts instead of duplicating them, and move example to general examples folder.

examples/slurm-example.sh Outdated Show resolved Hide resolved
examples/local_example.py Show resolved Hide resolved
examples/autopilot/createViews.py Outdated Show resolved Hide resolved
examples/autopilot/README Outdated Show resolved Hide resolved
examples/autopilot/multi-core-pilot.py Outdated Show resolved Hide resolved
examples/autopilot/multi-core-job.sh Outdated Show resolved Hide resolved
examples/autopilot/setup.sh Outdated Show resolved Hide resolved
@lnauta lnauta requested a review from hailihu January 2, 2025 15:29
@lnauta
Copy link
Member Author

lnauta commented Jan 2, 2025

The requested changes have been implemented, unfortunately, GH made them "outdated" when I moved files around. So I cant confirm the changes have been done. Anyway, they have been done.

@hailihu
Copy link
Collaborator

hailihu commented Jan 8, 2025

Great work! Some minor comments.

Copy link
Member Author

@lnauta lnauta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
(let's see if this submission changes the state if the PR, its not clear to me)

@hailihu
Copy link
Collaborator

hailihu commented Jan 10, 2025

Done. (let's see if this submission changes the state if the PR, its not clear to me)

What has been done? I don't see a new commit.

@lnauta
Copy link
Member Author

lnauta commented Jan 10, 2025

I approved the old 'outdated' changes, but this didnt do anything. I can't see the latest change request.

examples/local_example.py Outdated Show resolved Hide resolved
examples/single-core-job.sh Outdated Show resolved Hide resolved
examples/multi-core-job.sh Outdated Show resolved Hide resolved
examples/pushAutoPilotExampleTokens.py Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@hailihu
Copy link
Collaborator

hailihu commented Jan 10, 2025

I approved the old 'outdated' changes, but this didnt do anything. I can't see the latest change request.

Sorry, I didn't submit the review yet, done now.

@lnauta lnauta merged commit 3994721 into master Jan 14, 2025
4 checks passed
@lnauta lnauta deleted the SPD-417 branch January 14, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants