Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #32

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Minor fixes #32

merged 4 commits into from
Nov 22, 2024

Conversation

hailihu
Copy link
Collaborator

@hailihu hailihu commented Nov 20, 2024

  • Fix slurm_job_id for array jobs
  • In actors.py, remove while True loop to avoid infinite loop when exception occurs

This was linked to issues Nov 20, 2024
Incorrect slurm_job_id in tokens for array jobs #30
Closed
SSLEOFError #31
Closed
@hailihu hailihu marked this pull request as draft November 20, 2024 13:08
@hailihu hailihu requested a review from lnauta November 21, 2024 10:50
@hailihu hailihu marked this pull request as ready for review November 21, 2024 10:50
@hailihu hailihu mentioned this pull request Nov 22, 2024
Closed
lnauta
lnauta requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@lnauta lnauta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use f-strings over format if possible and check if the test is actually testing something.

picas/actors.py Outdated Show resolved Hide resolved
picas/actors.py Outdated Show resolved Hide resolved
tests/test_actors.py Show resolved Hide resolved
@hailihu hailihu requested a review from lnauta November 22, 2024 12:29
@hailihu
Copy link
Collaborator Author

hailihu commented Nov 22, 2024

Thanks, should be ready to merge now

lnauta
lnauta approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@lnauta lnauta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnauta lnauta merged commit 849d04d into master Nov 22, 2024
3 checks passed
@lnauta lnauta deleted the minor-fixes branch November 22, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnauta lnauta lnauta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSLEOFError Incorrect slurm_job_id in tokens for array jobs
2 participants
@hailihu @lnauta