Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix in scanner example #35

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Minor fix in scanner example #35

merged 1 commit into from
Jan 23, 2025

Conversation

hailihu
Copy link
Collaborator

@hailihu hailihu commented Jan 21, 2025

  • Change in picas/clients.py: task['input']) - > task['_id']), to make it work for Tropomi tokens that do not have field input
  • Move function arg_parser() from picas/util.py to local_example.py and core_scanner.py, because it is not a picas core functionality and it is confusing to set default arguments in a function that is not visible from the main program.

@hailihu hailihu requested a review from lnauta January 21, 2025 15:01
Copy link
Member

@lnauta lnauta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the _id, this is always available from CouchDB.
On the parser: this is very similar code used twice. If it comes up a third time we should generalize it.
And the scanner automates picas, which should become core functionality if you ask me. Users will want to automate when job numbers become large. At that point we could add the parser too.

@lnauta lnauta merged commit 8e36b14 into master Jan 23, 2025
4 checks passed
@lnauta lnauta deleted the fix-scanner branch January 23, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants