Merge pull request #968 from sarbagyastha/develop

Support for multiple video in single page for web + Refinements
sarbagyastha · Aug 3, 2024 · 13a9d17 · 13a9d17
2 parents e83fd21 + 6e7a86f
commit 13a9d17
Show file tree

Hide file tree

Showing 24 changed files with 515 additions and 435 deletions.
diff --git a/.github/workflows/web-deploy.yml b/.github/workflows/web-deploy.yml
@@ -14,5 +14,4 @@ jobs:
       - uses: subosito/flutter-action@v2
       - uses: sarbagyastha/flutter-gh-pages@main
         with:
-          workingDir: packages/youtube_player_iframe/example
-          baseHref: /youtube_player_flutter/
+          workingDir: packages/youtube_player_iframe/example
diff --git a/packages/youtube_player_iframe/CHANGELOG.md b/packages/youtube_player_iframe/CHANGELOG.md
@@ -1,4 +1,9 @@
 # Changelog
+## 5.1.4
+**Aug 3, 2024**
+- Bumps dependency to latest version.
+- Fixes issue where only one of player would initialize at a time in web.
+
 ## 5.1.3
 **Jul 1, 2024**
 - Bumps dependency to latest version.

diff --git a/packages/youtube_player_iframe/assets/player.html b/packages/youtube_player_iframe/assets/player.html
@@ -37,7 +37,7 @@
 
   <body>
     <div class="embed-container">
-      <div id="player"></div>
+      <div id="<<playerId>>"></div>
     </div>
 
     <script>
@@ -52,7 +52,7 @@
       var timerId;
 
       function onYouTubeIframeAPIReady() {
-        player = new YT.Player("player", {
+        player = new YT.Player("<<playerId>>", {
           host: host,
           playerVars: <<playerVars>>,
           events: {
@@ -120,10 +120,10 @@
       function sendPlatformMessage(message) {
         switch(platform) {
            case 'android':
-             YoutubePlayer.postMessage(message);
+             <<playerId>>.postMessage(message);
              break;
            case 'ios':
-             YoutubePlayer.postMessage(message, '*');
+             <<playerId>>.postMessage(message, '*');
              break;
            case 'web':
              window.parent.postMessage(message, '*');
@@ -132,11 +132,12 @@
       }
 
       function sendMessage(key, data) {
-         var message = {}
-         message[key] = data
+         var message = {};
+         message[key] = data;
+         message['playerId'] = '<<playerId>>';
          var messageString = JSON.stringify(message);
 
-         sendPlatformMessage(messageString)
+         sendPlatformMessage(messageString);
       }
 
       function getVideoData() {

diff --git a/packages/youtube_player_iframe/example/android/app/build.gradle b/packages/youtube_player_iframe/example/android/app/build.gradle
@@ -31,7 +31,7 @@ android {
 
     defaultConfig {
         applicationId "np.com.sarbagyastha.youtube_player_iframe_example"
-        minSdkVersion 19
+        minSdkVersion flutter.minSdkVersion
         targetSdkVersion 34
         versionCode flutterVersionCode.toInteger()
         versionName flutterVersionName

diff --git a/packages/youtube_player_iframe/example/ios/Flutter/AppFrameworkInfo.plist b/packages/youtube_player_iframe/example/ios/Flutter/AppFrameworkInfo.plist
@@ -21,6 +21,6 @@
   <key>CFBundleVersion</key>
   <string>1.0</string>
   <key>MinimumOSVersion</key>
-  <string>11.0</string>
+  <string>12.0</string>
 </dict>
 </plist>
diff --git a/packages/youtube_player_iframe/example/ios/Podfile b/packages/youtube_player_iframe/example/ios/Podfile
@@ -1,5 +1,5 @@
 # Uncomment this line to define a global platform for your project
-# platform :ios, '11.0'
+# platform :ios, '12.0'
 
 # CocoaPods analytics sends network stats synchronously affecting flutter build latency.
 ENV['COCOAPODS_DISABLE_STATS'] = 'true'

diff --git a/packages/youtube_player_iframe/example/ios/Runner.xcodeproj/project.pbxproj b/packages/youtube_player_iframe/example/ios/Runner.xcodeproj/project.pbxproj
@@ -167,7 +167,7 @@
 		97C146E61CF9000F007C117D /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 1430;
+				LastUpgradeCheck = 1510;
 				ORGANIZATIONNAME = "";
 				TargetAttributes = {
 					97C146ED1CF9000F007C117D = {
@@ -354,7 +354,7 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 12.0;
 				MTL_ENABLE_DEBUG_INFO = NO;
 				SDKROOT = iphoneos;
 				SUPPORTED_PLATFORMS = iphoneos;
@@ -436,7 +436,7 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 12.0;
 				MTL_ENABLE_DEBUG_INFO = YES;
 				ONLY_ACTIVE_ARCH = YES;
 				SDKROOT = iphoneos;
@@ -485,7 +485,7 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 11.0;
+				IPHONEOS_DEPLOYMENT_TARGET = 12.0;
 				MTL_ENABLE_DEBUG_INFO = NO;
 				SDKROOT = iphoneos;
 				SUPPORTED_PLATFORMS = iphoneos;

diff --git a/...youtube_player_iframe/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme b/...youtube_player_iframe/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1430"
+   LastUpgradeVersion = "1510"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"