Skip to content

Commit

Permalink
Merge pull request #103 from saritasa-nest/fix-querysets-for-viewsets
Browse files Browse the repository at this point in the history
Make queryset more consistent for ViewSets
  • Loading branch information
TheSuperiorStanislav authored Feb 18, 2025
2 parents 53d61a9 + 781f708 commit 5c64b27
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
5 changes: 5 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
History
=======

Unreleased
------------------

* Make querysets more consistent for ViewSets

1.4.0 (2025-01-28)
------------------

Expand Down
3 changes: 3 additions & 0 deletions import_export_extensions/api/views/export_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ class ExportJobViewSet(

def get_queryset(self):
"""Filter export jobs by resource used in viewset."""
if self.action == getattr(self, "export_action", ""):
# To make it consistent and for better support of drf-spectacular
return super().get_queryset() # pragma: no cover
return super().get_queryset().filter(
resource_path=self.resource_class.class_path,
)
Expand Down
3 changes: 3 additions & 0 deletions import_export_extensions/api/views/import_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ class ImportJobViewSet(

def get_queryset(self):
"""Filter import jobs by resource used in viewset."""
if self.action == getattr(self, "import_action", ""):
# To make it consistent and for better support of drf-spectacular
return super().get_queryset() # pragma: no cover
return super().get_queryset().filter(
resource_path=self.resource_class.class_path,
)
Expand Down

0 comments on commit 5c64b27

Please sign in to comment.