open files in utf-8 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the locale system-default is ASCII, the docker-build process of any project containing django-fontawesome-6 will fail.
added encoding utf-8 when opening file (utils.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not passing along an encoding-parameter to the open command, we rely on the default encoding being able to read the incoming files, which is not always the case for systems that have ASCII as their standard encoding. By specifying utf-8, we're on the safer side.
(Encoding problems occurred e.g. when starting docker containers made from debian images that tried to import the django-fontawesome-6 package, and the container couldn't start up in production-mode.)