Warn universal extensions on opaque types #22502
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
reviewed
Feb 3, 2025
| @@ -1190,7 +1191,7 @@ object RefChecks { | |||
| } | |||
| } | |||
| .exists | |||
| if !target.typeSymbol.isOpaqueAlias && hidden | |||
| if hidden | |||
There was a problem hiding this comment.
That line keeps getting shorter and shorter! 🥲
There was a problem hiding this comment.
I mean, it makes sense to say: if the extension method is hidden, then emit a warning
There was a problem hiding this comment.
It's so simple when you put it like that.
hamzaremmal
reviewed
Feb 3, 2025
| object Upperbound: | ||
| opaque type IArray[+T] <: String = String | ||
| extension (arr: IArray[Byte]) def length: Int = 0 // warn | ||
| extension [T <: Int](arr: T) def length: Int = 0 // nowarn |
There was a problem hiding this comment.
Won't harm to add this extra test
Suggested change
| extension [T <: Int](arr: T) def length: Int = 0 // nowarn | |
| extension [T <: IArray[Byte]](arr: T) def length: Int = 0 // warn |
hamzaremmal
reviewed
Feb 3, 2025
| extension (d: D) def equals(that: Any): Boolean = false // warn | ||
|
|
||
| object Upperbound: | ||
| opaque type IArray[+T] <: String = String |
There was a problem hiding this comment.
I wanted to suggest to change the name of the opaque type, I think we can all agree that IArray[+T] <: String = String is weird... Maybe:
Suggested change
| opaque type IArray[+T] <: String = String | |
| opaque type MyString <: String = String |
hamzaremmal
reviewed
Feb 3, 2025
|
|
||
| object NonUpperbound: | ||
| opaque type IArray[+T] = String | ||
| extension (arr: IArray[Byte]) def length: Int = 0 // nowarn |
There was a problem hiding this comment.
Suggested change
| extension (arr: IArray[Byte]) def length: Int = 0 // nowarn | |
| extension (arr: IArray[Byte]) def length: Int = 0 // nowarn | |
| extension [T <: IArray[Byte]](arr: T) def length: Int = 0 // nowarn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22232
Work also done by @hamzaremmal, @julian-a-avar-c and @nmcb