Consider source code as Scala 2 under -Ycompile-scala2-library
#22520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I haven't enabled |
|
CI is failing because of the string interpolators, I forgot that I changed it in 8cb6b70, we should probably use Scala 3's |
sjrd
previously approved these changes
Feb 6, 2025
hamzaremmal
force-pushed
the
hr/scala2-missing-flag
branch
from
885403e to
aa9074f
Compare
|
I've rebased it on top of #22536 because it failed to find the definitions of extension methods for |
hamzaremmal
force-pushed
the
hr/scala2-missing-flag
branch
from
aa9074f to
92c9a20
Compare
hamzaremmal
force-pushed
the
hr/scala2-missing-flag
branch
from
92c9a20 to
78c7473
Compare
hamzaremmal
dismissed
sjrd’s stale review
I've had to change the set of flags that are considered 'effectively open'
|
@WojciechMazur has run the open community build against this PR and no compile-time regression was found. |
sjrd
requested changes
Feb 11, 2025
compiler/src/dotty/tools/dotc/core/unpickleScala2/Scala2Unpickler.scala
Outdated
Show resolved
Hide resolved
hamzaremmal
force-pushed
the
hr/scala2-missing-flag
branch
from
dce5251 to
19c42ee
Compare
sjrd
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling under
-Ycompile-scala2-library, we should consider the source code as Scala 2. This change will allow using Scala 2's erasure instead of Scala 3's.Related to #22480