Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow private members when computing the denotation of a NamedType #22549

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

hamzaremmal
Copy link
Member

Closes #22548

@hamzaremmal hamzaremmal marked this pull request as ready for review February 7, 2025 15:55
@hamzaremmal hamzaremmal requested a review from odersky February 7, 2025 15:55
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks logical to do it this way.

@hamzaremmal
Copy link
Member Author

@odersky Do you mind also clicking on approve so it can be merged

@hamzaremmal hamzaremmal enabled auto-merge February 7, 2025 16:08
@hamzaremmal hamzaremmal merged commit 8d8b5b9 into scala:main Feb 7, 2025
26 checks passed
@hamzaremmal hamzaremmal deleted the i22548 branch February 7, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler crash when compiling value classes with an underlying private field
2 participants