sharding with empty inner chunk and index location start #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Can you check if the issue is also present in zarr-python? |
its no problem in zarr-python 👍🏼 @normanrz |
|
Actually it was also a problem in zarr-python. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sharding, empty inner chunks get marked by setting
nbytesandoffsetto-1in the index array. When usingindex_location="start"the size of the index array will be added to the offset.This PR will disable incrementing the
offsetfor empty inner chunks (thus, it still contains-1)(I have tested that in zarr-python aswell and it does not seem to be a problem there)