This repository has been archived by the owner on Nov 28, 2019. It is now read-only.
Sonatype Release #93
Open
Sonatype Release #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratoshniuk
commented
Mar 31, 2019
| key <- channel.register(selector, JSelectionKey.OP_ACCEPT) | ||
| buffer <- Buffer.byte(256) | ||
| _ <- started.succeed(()) | ||
| // key <- channel.register(selector, JSelectionKey.OP_ACCEPT) |
There was a problem hiding this comment.
fmt linter got failed on unused ones. so i commented them for now
There was a problem hiding this comment.
@ratoshniuk this line is needed for the test to pass. Just change key to _ and it should work.
There was a problem hiding this comment.
@ratoshniuk can you address this comment?
|
@ratoshniuk pls merge in master, this should solve current issue! |
pshemass
suggested changes
Jul 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.