Allow custom HTTP status code from AuthenticationRequiredHandler, #138

scheb · Apr 16, 2022 · 01fb822 · 01fb822
1 parent 526796a
commit 01fb822
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/bundle/Security/Http/Firewall/ExceptionListener.php b/src/bundle/Security/Http/Firewall/ExceptionListener.php
@@ -61,6 +61,7 @@ private function handleAccessDeniedException(ExceptionEvent $exceptionEvent): vo
         $this->eventDispatcher->dispatch($event, TwoFactorAuthenticationEvents::REQUIRE);
 
         $response = $this->authenticationRequiredHandler->onAuthenticationRequired($request, $token);
+        $exceptionEvent->allowCustomResponseCode();
         $exceptionEvent->setResponse($response);
     }
 

diff --git a/tests/Security/Http/Firewall/ExceptionListenerTest.php b/tests/Security/Http/Firewall/ExceptionListenerTest.php
@@ -103,6 +103,7 @@ private function assertNotHasResponse(ExceptionEvent $event): void
 
     private function assertHasResponse(ExceptionEvent $event, Response $response): void
     {
+        $this->assertTrue($event->isAllowingCustomResponseCode());
         $this->assertSame($response, $event->getResponse());
     }
-Original file line number
+Diff line change
@@ Expand Up @@
         private function assertHasResponse(ExceptionEvent $event, Response $response): void
         {
+            $this->assertTrue($event->isAllowingCustomResponseCode());
             $this->assertSame($response, $event->getResponse());
         }
@@ Expand Down @@