Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced hardcoded component keys with a dynamic mapped type based on… #54

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

starredev
Copy link
Contributor

### Svelte Custom Components for Schedule-X
Allow users to pass custom Svelte components (like timeGridEvent, headerContent, etc.) to Schedule-X in the same way as the Vue/React integration. Since CustomComponentName is in @schedule-x/shared there is no need for adding them manually.

Wrap up

  • Uses $$restProps to capture all custom component props dynamically
  • Registers them via calendarApp._setCustomComponentFn(...)
  • No need to manually declare each prop like export let timeGridEvent

Copy link
Contributor

@tomosterlund tomosterlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a ton for taking this on 🎉

Just left one question

@tomosterlund tomosterlund merged commit a0a4751 into schedule-x:main Mar 25, 2025
2 checks passed
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants