tests: check for dependency leaks (#43)

sclgo · Jan 24, 2025 · 34d0d16 · 34d0d16
1 parent 32851e8
commit 34d0d16
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -28,7 +28,7 @@ jobs:
 
     - name: Checks
       run: |
-        make check_changes
+        make check_changes check_deps        
 
     - name: Send coverage
       env:

diff --git a/.gitignore b/.gitignore
@@ -27,3 +27,4 @@ _testmain.go
 
 vendor/
 coverage/
+enumerateDB
diff --git a/Makefile b/Makefile
@@ -31,3 +31,11 @@ check_changes:
 # make sure .next.version contains the intended next version
 # if the following fails, update either the next version or undo any unintended api changes
 	go run golang.org/x/exp/cmd/gorelease@latest -version $(shell cat .next.version)
+
+check_deps:
+# checks for possibly leaked dependencies like in 
+# https://www.dolthub.com/blog/2022-11-07-pruning-test-dependencies-from-golang-binaries/
+	go build ./examples/enumerateDB.go	
+	strings enumerateDB | grep -m 1 github.com/sclgo/impala-go # sanity
+	! (strings enumerateDB | grep testify)
+	! (strings enumerateDB | grep docker)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -27,3 +27,4 @@ _testmain.go

		vendor/
		coverage/
		enumerateDB