tests: clearly mark generated code (#22)

rename /internal/services to /internal/generated to clearly mark such code This will help with more optimized testing and more accurate coverage stats.
sclgo · Jan 10, 2025 · b34649e · b34649e
1 parent d91d2fa
commit b34649e
Show file tree

Hide file tree

Showing 35 changed files with 37 additions and 37 deletions.
diff --git a/Makefile b/Makefile
@@ -1,8 +1,8 @@
 .PHONY: thrift
 thrift:
-	thrift -r -gen go:package_prefix=github.com/sclgo/impala-go/internal/services/ interfaces/ImpalaService.thrift
-	rm -rf ./internal/services
-	mv gen-go ./internal/services
+	thrift -r -gen go:package_prefix=github.com/sclgo/impala-go/internal/generated/ interfaces/ImpalaService.thrift
+	rm -rf ./internal/generated/
+	mv gen-go ./internal/generated/
 
 .PHONY: cli
 cli: usql

diff --git a/.../services/beeswax/GoUnusedProtection__.go → ...generated/beeswax/GoUnusedProtection__.go b/.../services/beeswax/GoUnusedProtection__.go → ...generated/beeswax/GoUnusedProtection__.go
diff --git a/internal/services/beeswax/beeswax-consts.go → internal/generated/beeswax/beeswax-consts.go b/internal/services/beeswax/beeswax-consts.go → internal/generated/beeswax/beeswax-consts.go
diff --git a/internal/services/beeswax/beeswax.go → internal/generated/beeswax/beeswax.go b/internal/services/beeswax/beeswax.go → internal/generated/beeswax/beeswax.go
diff --git a/..._service-remote/beeswax_service-remote.go → ..._service-remote/beeswax_service-remote.go b/..._service-remote/beeswax_service-remote.go → ..._service-remote/beeswax_service-remote.go
diff --git a/...vices/cli_service/GoUnusedProtection__.go → ...rated/cli_service/GoUnusedProtection__.go b/...vices/cli_service/GoUnusedProtection__.go → ...rated/cli_service/GoUnusedProtection__.go
diff --git a/...ervices/cli_service/cli_service-consts.go → ...nerated/cli_service/cli_service-consts.go b/...ervices/cli_service/cli_service-consts.go → ...nerated/cli_service/cli_service-consts.go
diff --git a/internal/services/cli_service/cli_service.go → ...rnal/generated/cli_service/cli_service.go b/internal/services/cli_service/cli_service.go → ...rnal/generated/cli_service/cli_service.go
diff --git a/..._service-remote/t_c_l_i_service-remote.go → ..._service-remote/t_c_l_i_service-remote.go b/..._service-remote/t_c_l_i_service-remote.go → ..._service-remote/t_c_l_i_service-remote.go
diff --git a/...al/services/fb303/GoUnusedProtection__.go → ...l/generated/fb303/GoUnusedProtection__.go b/...al/services/fb303/GoUnusedProtection__.go → ...l/generated/fb303/GoUnusedProtection__.go
diff --git a/...service-remote/facebook_service-remote.go → ...service-remote/facebook_service-remote.go b/...service-remote/facebook_service-remote.go → ...service-remote/facebook_service-remote.go
diff --git a/internal/services/fb303/fb303-consts.go → internal/generated/fb303/fb303-consts.go b/internal/services/fb303/fb303-consts.go → internal/generated/fb303/fb303-consts.go
diff --git a/internal/services/fb303/fb303.go → internal/generated/fb303/fb303.go b/internal/services/fb303/fb303.go → internal/generated/fb303/fb303.go
diff --git a/...es/hive_metastore/GoUnusedProtection__.go → ...ed/hive_metastore/GoUnusedProtection__.go b/...es/hive_metastore/GoUnusedProtection__.go → ...ed/hive_metastore/GoUnusedProtection__.go
diff --git a/...s/hive_metastore/hive_metastore-consts.go → ...d/hive_metastore/hive_metastore-consts.go b/...s/hive_metastore/hive_metastore-consts.go → ...d/hive_metastore/hive_metastore-consts.go
diff --git a/...services/hive_metastore/hive_metastore.go → ...enerated/hive_metastore/hive_metastore.go b/...services/hive_metastore/hive_metastore.go → ...enerated/hive_metastore/hive_metastore.go
diff --git a/...re-remote/thrift_hive_metastore-remote.go → ...re-remote/thrift_hive_metastore-remote.go b/...re-remote/thrift_hive_metastore-remote.go → ...re-remote/thrift_hive_metastore-remote.go
diff --git a/...ces/impalaservice/GoUnusedProtection__.go → ...ted/impalaservice/GoUnusedProtection__.go b/...ces/impalaservice/GoUnusedProtection__.go → ...ted/impalaservice/GoUnusedProtection__.go
diff --git a/...ces/impalaservice/ImpalaService-consts.go → ...ted/impalaservice/ImpalaService-consts.go b/...ces/impalaservice/ImpalaService-consts.go → ...ted/impalaservice/ImpalaService-consts.go
diff --git a/...l/services/impalaservice/ImpalaService.go → .../generated/impalaservice/ImpalaService.go b/...l/services/impalaservice/ImpalaService.go → .../generated/impalaservice/ImpalaService.go
diff --git a/...ote/impala_hive_server2_service-remote.go → ...ote/impala_hive_server2_service-remote.go b/...ote/impala_hive_server2_service-remote.go → ...ote/impala_hive_server2_service-remote.go
diff --git a/...a_service-remote/impala_service-remote.go → ...a_service-remote/impala_service-remote.go b/...a_service-remote/impala_service-remote.go → ...a_service-remote/impala_service-remote.go
diff --git a/...l/services/status/GoUnusedProtection__.go → .../generated/status/GoUnusedProtection__.go b/...l/services/status/GoUnusedProtection__.go → .../generated/status/GoUnusedProtection__.go
diff --git a/internal/services/status/Status-consts.go → internal/generated/status/Status-consts.go b/internal/services/status/Status-consts.go → internal/generated/status/Status-consts.go
diff --git a/internal/services/status/Status.go → internal/generated/status/Status.go b/internal/services/status/Status.go → internal/generated/status/Status.go
diff --git a/internal/hive/client.go b/internal/hive/client.go
@@ -6,7 +6,7 @@ import (
 	"strconv"
 
 	"github.com/apache/thrift/lib/go/thrift"
-	"github.com/sclgo/impala-go/internal/services/cli_service"
+	"github.com/sclgo/impala-go/internal/generated/cli_service"
 )
 
 // Client represents Hive Client

diff --git a/internal/hive/dbmetadata.go b/internal/hive/dbmetadata.go
@@ -10,7 +10,7 @@ import (
 	"time"
 
 	"github.com/samber/lo"
-	"github.com/sclgo/impala-go/internal/services/cli_service"
+	"github.com/sclgo/impala-go/internal/generated/cli_service"
 )
 
 type TableName struct {

diff --git a/internal/hive/dbmetadata_test.go b/internal/hive/dbmetadata_test.go
@@ -7,7 +7,7 @@ import (
 	"testing"
 
 	"github.com/google/uuid"
-	"github.com/sclgo/impala-go/internal/services/cli_service"
+	"github.com/sclgo/impala-go/internal/generated/cli_service"
 	"github.com/stretchr/testify/require"
 )
 

diff --git a/internal/hive/hive.go b/internal/hive/hive.go
@@ -4,7 +4,7 @@ import (
 	"errors"
 	"fmt"
 
-	"github.com/sclgo/impala-go/internal/services/cli_service"
+	"github.com/sclgo/impala-go/internal/generated/cli_service"
 )
 
 const (

diff --git a/internal/hive/metadata.go b/internal/hive/metadata.go
@@ -5,7 +5,7 @@ import (
 	"reflect"
 	"time"
 
-	"github.com/sclgo/impala-go/internal/services/cli_service"
+	"github.com/sclgo/impala-go/internal/generated/cli_service"
 )
 
 type TableSchema struct {

diff --git a/internal/hive/operation.go b/internal/hive/operation.go
@@ -6,7 +6,7 @@ import (
 	"time"
 
 	"github.com/samber/lo"
-	"github.com/sclgo/impala-go/internal/services/cli_service"
+	"github.com/sclgo/impala-go/internal/generated/cli_service"
 )
 
 const (

diff --git a/internal/hive/operation_test.go b/internal/hive/operation_test.go
@@ -5,7 +5,7 @@ import (
 	"log"
 	"testing"
 
-	"github.com/sclgo/impala-go/internal/services/cli_service"
+	"github.com/sclgo/impala-go/internal/generated/cli_service"
 	"github.com/stretchr/testify/require"
 )
 

diff --git a/internal/hive/result_set.go b/internal/hive/result_set.go
@@ -5,7 +5,7 @@ import (
 	"io"
 	"time"
 
-	"github.com/sclgo/impala-go/internal/services/cli_service"
+	"github.com/sclgo/impala-go/internal/generated/cli_service"
 )
 
 // ResultSet ...

diff --git a/internal/hive/result_set_test.go b/internal/hive/result_set_test.go
@@ -7,7 +7,7 @@ import (
 	"testing"
 
 	"github.com/samber/lo"
-	"github.com/sclgo/impala-go/internal/services/cli_service"
+	"github.com/sclgo/impala-go/internal/generated/cli_service"
 	"github.com/stretchr/testify/require"
 )
 

diff --git a/internal/hive/session.go b/internal/hive/session.go
@@ -3,7 +3,7 @@ package hive
 import (
 	"context"
 
-	"github.com/sclgo/impala-go/internal/services/cli_service"
+	"github.com/sclgo/impala-go/internal/generated/cli_service"
 )
 
 // Session represents hive session
-Original file line number
+Diff line change
@@ Expand Up / @@ -4,7 +4,7 @@ import ( @@
     	"errors"
     	"fmt"
-    	"github.com/sclgo/impala-go/internal/services/cli_service"
+    	"github.com/sclgo/impala-go/internal/generated/cli_service"
     )
     const (
@@ Expand Down @@