Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: root CA support regression #37

Merged
merged 1 commit into from
Jan 19, 2025
Merged

fix: root CA support regression #37

merged 1 commit into from
Jan 19, 2025

Conversation

murfffi
Copy link
Member

@murfffi murfffi commented Jan 19, 2025

The switch from the deprecated NewTBinaryProtocol to the recommended replacement NewTBinaryProtocolConf had an unintended side-effect - TLS configuration was propagated from the protocol to the transport, erasing the previously configured RootCAPool.

This PR fixes that and extends integration tests to cover TLS.

Closes #9

The switch from the deprecated NewTBinaryProtocol to the recommended replacement
NewTBinaryProtocolConf had an unintended side-effect - TLS configuration was
propagated from the protocol to the transport, erasing the previously configured RootCAPool.

This PR fixes that and extends integration tests to cover TLS.

Closes #9
@coveralls
Copy link

Coverage Status

coverage: 63.889% (+1.2%) from 62.675%
when pulling 8257206 on fix/tls
into e7349c7 on master.

@murfffi murfffi merged commit 780647b into master Jan 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: Extend integration tests
2 participants