Fix INSERT support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INSERT queries work now. The PR also removes some warnings, adds tests and comments. Testing Done: newly added integration test
|
For context, the equivalent code in the first-party client - impala-shell - is here - https://github.com/apache/impala/blob/master/shell/impala_shell.py#L1412 . A similar issue is open on bippio/go-impala since 2020 - bippio#27 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSERT statements work now. The PR also removes some warnings, adds tests and comments.
A few libraries are updated to resolve security notices.
Testing Done: newly added integration test