Make _calculateRotationCenter private...

and just return nativeRotationCenter in getSkinRotationCenter to do so.
scratchfoundation · Mar 4, 2021 · 9cb355c · 9cb355c
1 parent 1a32333
commit 9cb355c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/BitmapSkin.js b/src/BitmapSkin.js
@@ -90,7 +90,7 @@ class BitmapSkin extends Skin {
         this._costumeResolution = costumeResolution || 2;
         this._textureSize = BitmapSkin._getBitmapSize(bitmapData);
 
-        if (typeof rotationCenter === 'undefined') rotationCenter = this.calculateRotationCenter();
+        if (typeof rotationCenter === 'undefined') rotationCenter = this._calculateRotationCenter();
         this._nativeRotationCenter[0] = rotationCenter[0];
         this._nativeRotationCenter[1] = rotationCenter[1];
 

diff --git a/src/RenderWebGL.js b/src/RenderWebGL.js
@@ -753,7 +753,7 @@ class RenderWebGL extends EventEmitter {
      */
     getSkinRotationCenter (skinID) {
         const skin = this._allSkins[skinID];
-        return skin.calculateRotationCenter();
+        return skin.nativeRotationCenter;
     }
 
     /**

diff --git a/src/SVGSkin.js b/src/SVGSkin.js
@@ -300,7 +300,7 @@ class SVGSkin extends Skin {
         }
         this._nativeSize[0] = width;
         this._nativeSize[1] = height;
-        if (typeof rotationCenter === 'undefined') rotationCenter = this.calculateRotationCenter();
+        if (typeof rotationCenter === 'undefined') rotationCenter = this._calculateRotationCenter();
         this._nativeRotationCenter[0] = rotationCenter[0];
         this._nativeRotationCenter[1] = rotationCenter[1];
 

diff --git a/src/Skin.js b/src/Skin.js
@@ -125,7 +125,7 @@ class Skin extends EventEmitter {
      * Get the center of the current bounding box
      * @return {Array<number>} the center of the current bounding box
      */
-    calculateRotationCenter () {
+    _calculateRotationCenter () {
         return [this.nativeSize[0] / 2, this.nativeSize[1] / 2];
     }