lint clippy fix #17
Open
lint clippy fix #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9d97076.
Allow WHIR to process polynomials shorter than the folding factor. This is achieved by padding the short polynomial until it reaches 2^(folding_factor)
Fixed the bugs in the simple batching case and add tests. Use `cargo test --package whir --lib -- whir::tests::test_whir --exact --show-output` to run the new batching test.
…nto feat/ceno-binding-batch
…h#16) Finished batched openings on polynomials of the same size on different points. Main contributions: 1. Update the original simple_batch_prove to support multiple (or 0) points evaluated across all polynomials. 2. A new sumcheck protocol in `sumcheck/prover_batched` and `sumcheck/prover_not_skipping_batched` which uses a separate Eq polynomial for each point. 3. New `same_size_batch_prove` and `same_size_batch_verify` which first runs the new "unify" sumcheck to obtain the evaluation of all polynomials on the same point, and then perform regular WHIR operations. 4. New tests: `make_whir_batch_things_diff_point`. Remaining Issues: 1. One can imagine the support of multiple same / different opening points on each polynomial, not sure if this would be useful 2. Existing ceno interface of `prove_with_merlin_simple_batch`, etc. now requires copying the point and eval. This problem can be mitigated by making modifications in ceno. 3. Ceno interface for opening different points is not implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.