-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Ruff #147
Switch to Ruff #147
Conversation
A PR has been generated to the instance repo: You can check out the PR to preview your changes |
I think we could do without We already have a separate hook for pyupgrade. So there's not reason not to switch this to ruff I guess? |
We should switch that one to Ruff as well then! I mentioned why here: #142 (comment) |
Nice! What do you think about integrating nbqa (#141) in this PR as well? |
Let’s do that after, it’s already changing a lot, and I still need to do the doc changes |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This is ready from my side! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with some minor changes, questions
Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
Co-authored-by: Isaac Virshup <ivirshup@gmail.com>
All addressed, only |
Fixes #142.
Rendered docs
TODO:
At time of writing, Ruff supports the following out of all the flake8 plugins we use:
pydocstyle
/D
)Therefore at the time of writing this PR has only one regression:
flake8-rst-docstrings
would be gone without replacement. Is there something similar we could use?There’s many more good plugins we can consider, activating e.g.