Improve readability

seamapi · Sep 26, 2024 · db4cd6f · db4cd6f
1 parent 91ae178
commit db4cd6f
Showing 1 changed file with 29 additions and 9 deletions.
diff --git a/src/lib/code-sample/go.ts b/src/lib/code-sample/go.ts
@@ -31,23 +31,25 @@ export const createGoRequest = (
   _context: Context,
 ): string => {
   const parts = request.path.split('/')
-  const params = formatGoArgs(request.parameters ?? {})
   const isReqWithParams = Object.keys(request.parameters).length !== 0
 
   const goPackageName = getGoPackageName(request.path)
   const goPackageBasePath = 'github.com/seamapi/go'
 
-  const goPackageDefaultImport = `import ${GO_PACKAGE_CONFIG.defaultPackageName} "${goPackageBasePath}"`
-  const shouldImportNestedPackage =
-    goPackageName !== GO_PACKAGE_CONFIG.defaultPackageName
-  const goPackageNestedPackageImport = `import ${goPackageName} "${goPackageBasePath}/${goPackageName}"`
+  const goSdkImports = generateImports({
+    goPackageName,
+    goPackageBasePath,
+    shouldIncludeDefaultImport:
+      isReqWithParams || goPackageName === GO_PACKAGE_CONFIG.defaultPackageName,
+  })
 
   const requestStructName = getRequestStructName(request.path)
 
-  const goSdkRequestArgs = `context.Background()${isReqWithParams ? `, ${goPackageName}.${requestStructName}(${params})` : ''}`
+  const formattedParams = formatGoArgs(request.parameters)
+
+  const goSdkRequestArgs = `context.Background()${isReqWithParams ? `, ${goPackageName}.${requestStructName}(${formattedParams})` : ''}`
 
-  return `${isReqWithParams ? goPackageDefaultImport : ''}
-  ${shouldImportNestedPackage ? goPackageNestedPackageImport : ''}
+  return `${goSdkImports}
 
   client${parts.map((p) => pascalCase(p)).join('.')}(${goSdkRequestArgs})
   `
@@ -66,12 +68,30 @@ const getGoPackageName = (path: string): string => {
   const firstPart = parts[1]
 
   if (firstPart == null) {
-    throw new Error(`Invalid path: missing first part in "${path}"`)
+    throw new Error(`Invalid path: missing second part in "${path}"`)
   }
 
   return `${firstPart.replace(/_/g, '')}`
 }
 
+const generateImports = ({
+  goPackageName,
+  goPackageBasePath,
+  shouldIncludeDefaultImport,
+}: {
+  goPackageName: string
+  goPackageBasePath: string
+  shouldIncludeDefaultImport: boolean
+}): string => {
+  const goPackageDefaultImport = `import ${GO_PACKAGE_CONFIG.defaultPackageName} "${goPackageBasePath}"`
+  const shouldImportNestedPackage =
+    goPackageName !== GO_PACKAGE_CONFIG.defaultPackageName
+  const goPackageNestedPackageImport = `import ${goPackageName} "${goPackageBasePath}/${goPackageName}"`
+
+  return `${shouldIncludeDefaultImport ? goPackageDefaultImport : ''}
+  ${shouldImportNestedPackage ? goPackageNestedPackageImport : ''}`.trim()
+}
+
 const getRequestStructName = (path: string): string => {
   const requestStructNameSuffix = 'Request'