Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove default export #27

Merged
merged 2 commits into from
Feb 27, 2024
Merged

feat: Remove default export #27

merged 2 commits into from
Feb 27, 2024

Conversation

razor-x
Copy link
Member

@razor-x razor-x commented Feb 17, 2024

Mixing named and default exports issues a build warning for commonjs because it can create hard to debug issues with different bundlers and JS environments.

Consumers using

import Seam from 'seam'

Should instead use

import { Seam } from 'seam'

Copy link
Contributor

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 agree

@razor-x
Copy link
Member Author

razor-x commented Feb 27, 2024

Needs seamapi/docs#248

@razor-x razor-x merged commit 9d3ca1f into main Feb 27, 2024
13 checks passed
@razor-x razor-x deleted the remove-default-export branch February 27, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants