-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error Snackbar
to table components
#505
Conversation
Any thoughts on how to trigger a loading error in a story? Maybe we need a workspace on the fake that always returns errors on get / list? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@razor-x an erroring workspace isn't a bad idea. How would you go about that? |
We can just add a DB method to the fake to configure some behavior, like @seveibar I know you have thought about this, did you ever have a particular API in mind? |
@razor-x that pattern seems ok, although id always suggest documenting specific known bugs or scenarios when making simulation endpoints. In this case its not a bug we're replicating in the fake and the function is unlikely to cover up a bug (if it was repurposed) so i think its good! |
That makes sense. In this case the error is a generic issue that could be caused by anything. But we could name it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a way to test this on storybook before we can merge it to make sure it renders correctly over the components.
src/lib/seam/components/ClimateSettingScheduleTable/ClimateSettingScheduleTable.tsx
Outdated
Show resolved
Hide resolved
@razor-x I believe this PR should be all unblocked now. Did some local testing and your recent fix seems to have patched up all the issues I had previously. |
Depends on #504 and #514