Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm and github versions discrepancy #109

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Fix npm and github versions discrepancy #109

merged 8 commits into from
Feb 29, 2024

Conversation

kainpets
Copy link
Member

Fixes #99

@kainpets kainpets requested a review from razor-x February 29, 2024 15:57
@kainpets kainpets marked this pull request as ready for review February 29, 2024 16:19
seveibar
seveibar suggested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pver release needs to be run before the "Get the version from package.json", since pver release is what increments the version

@kainpets kainpets requested a review from seveibar February 29, 2024 16:39
@kainpets kainpets merged commit 236f438 into main Feb 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

@razor-x razor-x Awaiting requested review from razor-x

@andrii-balitskyi andrii-balitskyi Awaiting requested review from andrii-balitskyi andrii-balitskyi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create release per npm release
2 participants
@kainpets @seveibar