Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to set/remove object params (set custom_metadata) #75

Closed
wants to merge 2 commits into from

Conversation

mikewuu
Copy link
Contributor

@mikewuu mikewuu commented Jan 23, 2024

closes #74

The error was actually due to not selecting a valid param because the cli was performing a search (not a text input).

Handled this via:

  if (paramToEdit === undefined) {
    return args.params
  }

Which basically just returns existing params gracefully instead.

This PR also adds the ability to set/remove properties on an object type param.

Screenshots

CleanShot.2024-01-23.at.12.14.06.mp4

@mikewuu mikewuu changed the title feat: handle updating objects feat: add ability to set/remove object params (set custom_metadata) Jan 23, 2024
@mikewuu
Copy link
Contributor Author

mikewuu commented Jan 24, 2024

@seveibar do we need to handle sub-properties in general? If not, I'll close this out in favor of #77

@mikewuu
Copy link
Contributor Author

mikewuu commented Jan 25, 2024

closing in favor of #77

@mikewuu mikewuu closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI doesn't support "update custom_metadata"
1 participant