Fourth frontend features and some backend fixes #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vityaman
reviewed
Jan 15, 2025
Comment on lines
+102
to
+107
| client: | ||
| ssl: | ||
| key-store-type: PKCS12 | ||
| key-store: classpath:keystore/itmo-dating-backend.p12 | ||
| key-store-password: ${KEY_STORE_PASSWORD} | ||
| protocol: TLSv1.3 |
There was a problem hiding this comment.
Хммм, а может быть это даже можно в какой-то общий для всех модуль унести, потому что я для работы WebClient сам велосипедно SSLContext собираю. Может быть, эта штука сделает так, чтобы оно работало само.
| @@ -14,5 +14,6 @@ class MatchmakerSecuredPaths : SpringSecuredPaths { | |||
| Path("/api/**"), | |||
| Not(Path("/api/people/{person_id}", HttpMethod.PUT)), | |||
| Not(Path("/api/monitoring/healthcheck", HttpMethod.GET)), | |||
| Not(Path("/api/suggestions", HttpMethod.OPTIONS)), | |||
There was a problem hiding this comment.
Тут, наверное, нужно сделать какой-нибудь wildcard и все OPTIONS разрешить возмоооожно.
Comment on lines
+19
to
+30
| console.error('Error getting locations: ', error) | ||
| //TODO remove after integration with backend | ||
| setLocations([ | ||
| { | ||
| id: 1, | ||
| name: 'ITMO University, Kronverkskiy Avenue', | ||
| coordinates: { | ||
| latitude: 59.957478, | ||
| longitude: 30.308014, | ||
| }, | ||
| }, | ||
| ]) |
Comment on lines
+19
to
+21
| console.error('Error getting faculties: ', error) | ||
| //TODO remove after integration with backend | ||
| setFaculties([{ id: 1, longName: 'piict' }]) |
Comment on lines
+18
to
+27
| axios | ||
| .get(url, config) | ||
| .then((response) => { | ||
| console.log(response.data) | ||
| setPersonIdArray(response.data) | ||
| }) | ||
| .catch((error) => { | ||
| console.error('Error getting suggestions: ', error) | ||
| setPersonIdArray([]) | ||
| }) |
There was a problem hiding this comment.
Эх, заведу отдельный тикет на использование сгенерированного из OpenAPI клиента для фронта.
Comment on lines
+13
to
+16
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Authorization: basicAuth, | ||
| }, |
There was a problem hiding this comment.
БТВ, дублирование вот этого фрагмента повсюду.
Comment on lines
+205
to
+210
| icon: { | ||
| id: 123, | ||
| small: 'https://avatars.githubusercontent.com/u/93886405', | ||
| medium: 'https://avatars.githubusercontent.com/u/93886405', | ||
| large: 'https://avatars.githubusercontent.com/u/93886405', | ||
| }, |
There was a problem hiding this comment.
Думаю, в будущей апишке не будет small, medium, large. Будет только large сперва.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.