Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🎨 use current css elements #297

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Conversation

signekb
Copy link
Member

@signekb signekb commented Dec 3, 2024

Description

This updates the blocks to use the current css elements from the seedcase-theme. It also removes the reference to a non-existent landing-page-theme.css file (which was removed at some point).

This should fix the build problem that we currently have.

This PR needs a quick review.

Checklist

  • Ran spell-check
  • Formatted Markdown (Quarto visual mode)
  • Rendered website locally

This updates the blocks to use the current css elements from the seedcase-theme. It also removes the reference to a non-existent landing-page-theme.css file (which was removed at some point).
@signekb signekb requested a review from a team as a code owner December 3, 2024 14:40
@signekb
Copy link
Member Author

signekb commented Dec 3, 2024

OK, in regards to formatting I don't know what's up. I went into Quarto's visual mode and it made the changes I have pushed here. But, when I did it again, locally, it undid these changes like this:

image

🤷 🤷‍♀️ 🤷 🤷‍♂️

Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There was some issues with a missing bracket and something with the closing divs, so fixed those, removed the footnote (it went all the way to the end of the screen which didn't look good, plus it isn't necessary here), and kept the width on the NNF logo, it got too big on my screen.

@lwjohnst86 lwjohnst86 merged commit fafc8d6 into main Dec 3, 2024
@lwjohnst86 lwjohnst86 deleted the fix/website-formatting branch December 3, 2024 17:57
@signekb
Copy link
Member Author

signekb commented Dec 4, 2024

Oh, something seems to have gone wrong there. I didn't intend to remove/change the width of the NNF logo.

@lwjohnst86
Copy link
Member

Yea I fixed it 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants