Implement a auto re-trying wrapper backend #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grote
force-pushed
the
retry-backend
branch
8 times, most recently
from
f22428c to
f41a8df
Compare
See: https://developer.android.com/develop/background-work/background-tasks/broadcasts#android-14 for why we don't get broadcasts while the system has us in cached state
We forgot the app size, so when restoring apps, their data size was unknown
|
So #796 is what this PR itself refers to, and the others listed are the unrelated ones? I left comments on the others, which appear fixed, but I still need to test the main issue. |
Yes.
Thanks! |
Test case 1 (with WebDAV)
Expected resultBackup retries transient failures and ultimately completes successfully.(?) Actual resultBackup claimed to finish successfully. However, during the process, the backup got stuck for a while on RHVoice while the network was not available. When using the Restore functionality, RHVoice is shown with "Last backup: Never (0 B)", but that is not the case for the previous backup - so I think although the backup "finished successfully", on the apps which failed, it gave up. Still working on replicating this. LogFull log shared privately with filename snippet |
|
Re Test case 1 above: @grote and I were perplexed to see lines like |
|
I pushed some changes that new will retry |
|
|
Thanks for testing! I just added the |
|
Understood! The StreamResetException just came up in my first test and made it appear that this change change was ineffective until looking at logs to see why. |
t-m-w
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data to be saved to the backend will now be kept in memory and not directly written to streams. So watch out for out of memory errors!
This allows us to keep the data available for re-tries. If a network request times out or fails in a non-permanent way, the new
RetryBackendwill automatically retry all backend operations. Over time, we can find out more transient exceptions and add them to the list. For now, we start small with few real tr-try cases.For ease of combined testing, this MR contains commits that fix unrelated issues:
Closes #796, #828, #830, #841