Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/feat/resnet #27

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Add/feat/resnet #27

merged 3 commits into from
Sep 16, 2024

Conversation

ramiro999
Copy link
Contributor

Description

Provide a detailed description of your changes and why they are necessary.

Checklist

Ensure your pull request meets the following requirements:

  • I have reviewed existing notebooks to avoid duplications.
  • My notebook is fully executed.
  • I have included a list of all libraries and their versions used in the notebook.
  • The notebook file is named clearly to reflect the topic (e.g., cross-entropy-loss.ipynb).
  • I have placed the notebook in the appropriate directory under notebooks/.
  • My code is simple, precise, and adheres to good coding practices.

Linked Issues

List any related issues this pull request addresses.
e.g., "Fixes #123"

Additional Information

Any other information you want to include?
Include any other context, screenshots, or details that might help understand your changes.

Copy link
Member

@guillepinto guillepinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You should add the notebook in the csv, check the contribution rules

  2. In the future it could be generalized, resnet can be created with various numbers of layers, currently it is only implemented for 56

@guillepinto guillepinto changed the title Add/feat/resnet_50 Add/feat/resnet Sep 16, 2024
Copy link
Member

@guillepinto guillepinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for the notebook!

@guillepinto guillepinto merged commit 3cf1146 into main Sep 16, 2024
@guillepinto guillepinto deleted the feat/resnet-50 branch September 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants