Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dino #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feat/dino #29

wants to merge 2 commits into from

Conversation

Jleon13
Copy link

@Jleon13 Jleon13 commented Dec 2, 2024

Description

Provide a detailed description of your changes and why they are necessary.

Checklist

Ensure your pull request meets the following requirements:

  • I have reviewed existing notebooks to avoid duplications.
  • My notebook is fully executed.
  • I have included a list of all libraries and their versions used in the notebook.
  • The notebook file is named clearly to reflect the topic (e.g., cross-entropy-loss.ipynb).
  • I have placed the notebook in the appropriate directory under notebooks/.
  • My code is simple, precise, and adheres to good coding practices.

Linked Issues

List any related issues this pull request addresses.
e.g., "Fixes #123"

Additional Information

Any other information you want to include?
Include any other context, screenshots, or details that might help understand your changes.

Copy link
Member

@guillepinto guillepinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook name must be in lower case. The versions of some libraries are also missing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although torchinfo is installed and the call torchsummary is also done, they are never used, I suggest to remove them if they are not going to be used or use summary of torchinfo to see the model modules as in vit

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants