feat: etherfi claim script #51
Conversation
| transferCalls[1] = RumpelModule.Call({ | ||
| safe: ISafe(v.userAdd), | ||
| to: MAINNET_LRT2, | ||
| data: abi.encodeWithSelector(ERC20.transfer.selector, owners[0], v.stakingRewards), |
There was a problem hiding this comment.
if v.stakingRewards == 0 don't make this tx
There was a problem hiding this comment.
A suggestion and a question, but nothing blocking! Nice one
Will review https://github.com/sense-finance/rumpel-root-vercel/pull/145/files now
| // Overrides for wallets who have already claimed king | ||
| // Note the amount they've previously claimed and remove it from their staked rewards | ||
| // https://etherscan.io/tx/0xa7cb70a54384efcc0d265157e20331f94dd998c28f0e961435193220ccd9d2f4 | ||
| uint256 public USER_OVERRIDE_PREV_TRANSFER_1 = 19386471377007458; // wallet = 0xce2f33c58f7aF3338a9D4Bd7baAf6F4a01E1Ea30 |
There was a problem hiding this comment.
We could get these same values just-in-time by checking cumulativeClaimed on the lrt2Claim contract, right?
There was a problem hiding this comment.
Yes, I think this would work combined with a validation that the rumpel wallet balance is zero, to confirm it was both claimed and removed from the wallet, and that the amount we calculate and transfer will result in a 0 king balance in the rumpel wallet.
| revert("ERROR: Current Root not expected"); | ||
| } | ||
|
|
||
| while (true) { |
There was a problem hiding this comment.
Ahh so, from a quick look at the rewards json, is it that in HistoricalRewards the order of the array varies (seems like staking and point awards switch between index 0 and 1?)
There was a problem hiding this comment.
yes - for that reason, the code iterates the array entries until it finds the entry with the desired root.
| // SPDX-License-Identifier: AGPL-3.0-only | ||
| pragma solidity =0.8.24; | ||
|
|
||
| import {Script, console} from "forge-std/Script.sol"; |
There was a problem hiding this comment.
nit: doesn't matter at all but could remove console import
No description provided.