Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usde Pendle YTs to the guard. #34

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add usde Pendle YTs to the guard. #34

merged 1 commit into from
Jan 29, 2025

Conversation

mijovic
Copy link
Contributor

@mijovic mijovic commented Jan 28, 2025 •
edited
Loading

  • Add safe batches

@mijovic mijovic marked this pull request as draft January 28, 2025 13:48
stevenvaleri
stevenvaleri approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@stevenvaleri stevenvaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- validated the YT address against pendle's front end.

Will need the safe contract batch json and a merge with main.

jparklev
jparklev approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@jparklev jparklev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes – lgtm! (woot, first dorde PR 🍾 )

seconded on merging in main – should fix any problems with the build.

were you able to run the new function with forge script successfully?

jparklev
jparklev reviewed Jan 28, 2025
View reviewed changes
script/RumpelConfig.sol Outdated
configs[0] = TokenGuardConfig({
token: MAINNET_PENDLE_YT_USDE_27MAR2025,
transferAllowState: RumpelGuard.AllowListState.ON,
approveAllowState: RumpelGuard.AllowListState.ON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for most of the other YTs, we don't actually add approve to the allowlist (see getFluidSusdeAndYTsTokenGuardConfigs function as an example). The idea is to allow the minimal number of functions, and users don't need to deposit their YTs into anything (which would require approve), so we haven't added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, makes sense
I changed to OFF for now

@mijovic mijovic force-pushed the pendle_usde branch 2 times, most recently from 484665e to 95d3e9e Compare January 29, 2025 12:36
@mijovic mijovic marked this pull request as ready for review January 29, 2025 12:37
@stevenvaleri
Copy link
Contributor

@mijovic re-ran the batch script to remove the approve update

@stevenvaleri
Copy link
Contributor

@jparklev queued: https://app.safe.global/transactions/queue?safe=eth:0x9D89745fD63Af482ce93a9AdB8B0BbDbb98D3e06

@jparklev
Copy link
Contributor

jparklev commented Jan 29, 2025 •
edited
Loading

confirmed: https://app.safe.global/transactions/tx?safe=eth:0x9D89745fD63Af482ce93a9AdB8B0BbDbb98D3e06&id=multisig_0x9D89745fD63Af482ce93a9AdB8B0BbDbb98D3e06_0x9c988d6395f01b57e19610f1c2e72a69fde9f18b3ce0142977e9f36de46d9c72

@mijovic mijovic merged commit 776433b into main Jan 29, 2025
2 checks passed
@mijovic mijovic deleted the pendle_usde branch January 29, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparklev jparklev jparklev approved these changes

@stevenvaleri stevenvaleri stevenvaleri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mijovic @stevenvaleri @jparklev