feat: add swap owner to allowlist, test #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenvaleri
approved these changes
Feb 4, 2025
stevenvaleri
reviewed
Feb 4, 2025
| assertEq(ISafe(safe).getOwners()[0], NEW_OWNER); | ||
| } | ||
|
|
||
| function _execSafeTx(ISafe safe, address to, uint256 value, bytes memory data, Enum.Operation operation) public { |
There was a problem hiding this comment.
A future clean up could be adding this function to a base test contract helper since its in most test files
stevenvaleri
reviewed
Feb 4, 2025
| function removeOwner(address prevOwner, address owner, uint256 _threshold) external; | ||
|
|
||
| function swapOwner(address prevOwner, address oldOwner, address newOwner) external; | ||
|
|
There was a problem hiding this comment.
This doesn't work so nicely with my print-state script, since it knows functions in the config contract but not sure we should make decisions based on that.
I can also update the print functionality to also get all functions from contracts in the src folder
There was a problem hiding this comment.
easy enough to change – moved it into the config file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.