feat: Add mellow vaults. #38
Conversation
mijovic
force-pushed
the
mellow_vaults
branch
2 times, most recently
from
f58da10 to
749eab8
Compare
|
this is still in draft, but ready for review, right @mijovic? |
Yes, it is ready, you are right. |
There was a problem hiding this comment.
Looking good! A few tiny things, and then a point about adding deposit assets as well as the strategy assets. Historically, we've added both so that users have two ways to get into a position on their rumpel wallet (deposit vault share, or deposit underlying and enter position via wallet). I think it makes sense to keep doing that, with the notable exception of ENA
mijovic
force-pushed
the
mellow_vaults
branch
from
749eab8 to
a86b643
Compare
There was a problem hiding this comment.
Comment on wBTC – otherwise LGTM!
Once this gets confirmed by @stevenvaleri, we can queue up the tx on the admin multsig, and merge this once confirmed
mijovic
force-pushed
the
mellow_vaults
branch
from
a86b643 to
09e8047
Compare
| address public constant MAINNET_MELLOW_SIBTC = 0xE4357bDAE017726eE5E83Db3443bcd269BbF125d; | ||
| address public constant MAINNET_MELLOW_LUGAETH = 0x82dc3260f599f4fC4307209A1122B6eAa007163b; | ||
| address public constant MAINNET_MELLOW_ROETH = 0x7b31F008c48EFb65da78eA0f255EE424af855249; | ||
| address public constant MAINNET_MELLOW_RSUNIBTC = 0x08F39b3d75712148dacDB2669C3EAcc7F1152547; |
There was a problem hiding this comment.
I think we should consider either making the variable name the name of the vault on the UI, or the add the name of the vault on the UI to the comments on the right b/c it was a bit of work to backwards map the symbol to the vault on the UI for verifying. I think comment would help keep the variable name short.
Update not required for this PR.
Co-authored-by: Steven Valeri <steven@sense.finance>
mijovic
force-pushed
the
mellow_vaults
branch
from
300f737 to
8649eac
Compare
There was a problem hiding this comment.
Nice -- checked all contract deposit / withdraw functions and they line up correctly.
For getProtocolGuardConfigMellowSymbiotic let's include the function claim which becomes required when not all funds are immediately available for withdrawal:
|
@jparklev added the claim function and optimistically queued |
|
TODO: