feat: symbiotic batch 3 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparklev
reviewed
Feb 13, 2025
script/RumpelConfig.sol
Outdated
| configs[2] = TokenGuardConfig({ | ||
| token: MAINNET_SYMBIOTIC_SFRXETH_COLLATERAL, | ||
| transferAllowState: RumpelGuard.AllowListState.ON, | ||
| approveAllowState: RumpelGuard.AllowListState.OFF |
There was a problem hiding this comment.
In the other two PRs, I think we add the approve function for symbiotic collat tokens too. (eg) any reason for the difference?
There was a problem hiding this comment.
yes - should be ON. This will allow for users to migrate to new vaults. I'll update.
( not including the newer vaults, which don't have transfer or approve as you mentioned )
| @@ -40,6 +40,11 @@ library RumpelConfig { | |||
| address public constant MAINNET_ZIRCUIT_RESTAKING_POOL = 0xF047ab4c75cebf0eB9ed34Ae2c186f3611aEAfa6; | |||
| address public constant MAINNET_SYMBIOTIC_WSTETH_COLLATERAL = 0xC329400492c6ff2438472D4651Ad17389fCb843a; | |||
| address public constant MAINNET_SYMBIOTIC_SUSDE_COLLATERAL = 0x19d0D8e6294B7a04a2733FE433444704B791939A; | |||
| address public constant MAINNET_SYMBIOTIC_MEV_CAPITAL_WSTETH_COLLATERAL = 0x4e0554959A631B3D3938ffC158e0a7b2124aF9c5; | |||
There was a problem hiding this comment.
Similar to https://github.com/sense-finance/rumpel-wallet/pull/41/files#r1953753194, this contract doesn't seem to have a transfer function. are you seeing the same?
There was a problem hiding this comment.
yes - will review and update
stevenvaleri
changed the title
|
@jparklev queued - nonce 33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-Scope Strategies (4)
MEV-wstETH
sfrxETH
Gauntlet-swETH
ETHFI
lvlwaUSDC - on hold. Error on deposit.
MEV-wstETH
defaultCollateral.deposit
defaultCollateral.withdraw
defaultCollateral.transferthese functions are not on the vaultdefaultCollateral.approvethese functions are not on the vault[underlying already approved]
sfrxETH
defaultCollateral.deposit
defaultCollateral.withdraw
defaultCollateral.transfer
defaultCollateral.approve
underlying.transfer
underlying.approve
Gauntlet-swETH
defaultCollateral.deposit
defaultCollateral.withdraw
defaultCollateral.transfer
defaultCollateral.approve
[underlying approved in batch 2]
potential reward token, limited approvals
ETHFI
defaultCollateral.transfer
defaultCollateral.approve