Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits #79

Merged
merged 4 commits into from
Jan 11, 2025
Merged

Minor edits #79

merged 4 commits into from
Jan 11, 2025

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • GRIND_WARNING_MESSAGE updated
  • Minor edits in tests

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this Jan 10, 2025
@sepandhaghighi sepandhaghighi added the enhancement New feature or request label Jan 10, 2025
@sepandhaghighi sepandhaghighi added this to the mycoffee v1.2 milestone Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (09d7ffc) to head (0004e12).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          126       126           
  Branches        26        26           
=========================================
  Hits           126       126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sepandhaghighi sepandhaghighi marked this pull request as ready for review January 11, 2025 00:42
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to mention something regarding these changes in the changelog.

@sepandhaghighi
Copy link
Owner Author

I think we need to mention something regarding these changes in the changelog.

There is no need to update CHANGELOG.md since we included this option in this version.

@sadrasabouri sadrasabouri merged commit 8b4b544 into dev Jan 11, 2025
28 checks passed
@sadrasabouri sadrasabouri deleted the minor_edits branch January 11, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants