-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use container-alpha1v2 endpoint #62
Conversation
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
|
if the add --await to the failed test, I get this error:
|
It seems that the freeze functionality of alpha1v2/container endpoint is not correctly working |
test is failing beacuse now freeze is also returning the image name in targetImage and not in containerImage wave-cli/app/src/main/java/io/seqera/wave/cli/App.java Lines 630 to 633 in 578b504
|
As per the wave change in the below mentioned link, we are null to containerImage incase of V2, so I will make the change in wave-cli to only output targetImage |
Signed-off-by: munishchouhan <hrma017@gmail.com>
|
Using the new endpoint the await needs to be re-implemented so that when the |
This change needs BuildStatusResponse in wave-cli also, to access the status, I will create a PR in libseqera to add the same there |
Signed-off-by: munishchouhan <hrma017@gmail.com>
depends upon seqeralabs/libseqera#20 |
@pditommaso as now we are using status endpoint, should we check if the build succeeded or not and if only succeeded then only output the image name while using await or some error message? |
Let's just check the for complete status for now. It could be added the error check later |
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: munishchouhan <hrma017@gmail.com>
converting it to draft, getting error while using await for cached image, will fix and make it ready for review
|
Signed-off-by: munishchouhan <hrma017@gmail.com>
This error is coming because now v2 endpoint is sending the containerImage name in targetImage and that's making imageToManifestUri method to create wrong url
|
I think when its freeze, we should only check the build endpoint in await state |
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: munishchouhan <hrma017@gmail.com>
@pditommaso can you please check the await functionality change and see if this is the intended functionality? |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
I gave it another try to simplify it a bit |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Old client:
Old client:
|
Test sending the same requests again requests: success no wait time
|
Testing after deleting images from the repo and invalidating the cache, and repeating the commands is also successful |
@munishchouhan Is this still relevant ? seqeralabs/wave#423 (comment) Thank you |
I think this is a rare scenario, so we can ignore this in this effort. Now I only one item still open about the delay in between in status API calls |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Let's finish this fixing the wait loop and the await timeout |
sure, working on it |
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: munishchouhan <hrma017@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This PR uses the container-alpha1v2 endpoint. See seqeralabs/wave#435