Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change /view/scans to post #802

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Change /view/scans to post #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b55ec7
change /view/scan to post
munishchouhan Feb 27, 2025
7867027
remove unwanted import
munishchouhan Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/groovy/io/seqera/wave/controller/ViewController.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ import io.micronaut.core.annotation.Nullable
import io.micronaut.http.HttpRequest
import io.micronaut.http.HttpResponse
import io.micronaut.http.HttpStatus
import io.micronaut.http.annotation.Body
import io.micronaut.http.annotation.Controller
import io.micronaut.http.annotation.Get
import io.micronaut.http.annotation.Post
import io.micronaut.http.annotation.QueryValue
import io.micronaut.http.client.HttpClient
import io.micronaut.http.client.annotation.Client
Expand All @@ -56,7 +58,6 @@ import io.seqera.wave.service.scan.ScanEntry
import io.seqera.wave.service.scan.ScanVulnerability
import io.seqera.wave.util.JacksonHelper
import jakarta.inject.Inject
import jakarta.ws.rs.QueryParam
import org.reactivestreams.Publisher
import org.reactivestreams.Subscriber
import org.reactivestreams.Subscription
Expand Down Expand Up @@ -315,8 +316,8 @@ class ViewController {
* @return
* The redirect response to the scan view for the requested container image
*/
@Get('/scans')
Publisher<HttpResponse> requestScan(@QueryParam String image) {
@Post('/scans')
Publisher<HttpResponse> requestScan(@Body String image) {
final req = new SubmitContainerTokenRequest(containerImage: image, scanMode: ScanMode.required)
final post = HttpRequest.POST("/v1alpha2/container", req)
final resp = httpClient.retrieve(post, SubmitContainerTokenResponse)
Expand Down
4 changes: 2 additions & 2 deletions src/test/groovy/io/seqera/wave/controller/ViewControllerTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,8 +790,8 @@ class ViewControllerTest extends Specification {
def image = "ubuntu:latest"
and:
def req = java.net.http.HttpRequest.newBuilder()
.GET()
.uri(new URI("${uri}/view/scans?image=${image}"))
.POST(java.net.http.HttpRequest.BodyPublishers.ofByteArray(image.bytes))
.uri(new URI("${uri}/view/scans"))
.build()

when:
Expand Down