feat: Add support for cluster api/capmox #166
Conversation
There was a problem hiding this comment.
Looks great! The implementation is very simple. I thought it would be much harder.
You can switch to the CAPI ProviderID using an environment parameter or proxmox-config, like
features:
# capmox is code name of providerID format
provider: capmox
clusters: []you can use different name capmox it is just example.
| | Key | Type | Default | Description | | ||
| |-----|------|---------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | replicaCount | int | `1` | | | ||
| | image.repository | string | `"ghcr.io/sergelogvinov/proxmox-cloud-controller-manager"` | Proxmox CCM image. | | ||
| | image.pullPolicy | string | `"IfNotPresent"` | Always or IfNotPresent | | ||
| | image.tag | string | `""` | Overrides the image tag whose default is the chart appVersion. | | ||
| | imagePullSecrets | list | `[]` | | | ||
| | nameOverride | string | `""` | | | ||
| | fullnameOverride | string | `""` | | | ||
| | extraArgs | list | `[]` | Any extra arguments for talos-cloud-controller-manager, eg --capi=true to enable cluster api compatibility. | | ||
| | enabledControllers | list | `["cloud-node","cloud-node-lifecycle"]` | List of controllers should be enabled. Use '*' to enable all controllers. Support only `cloud-node,cloud-node-lifecycle` controllers. | |
There was a problem hiding this comment.
This file auto generated by command make docs
Better to add comments in values.yaml see # -- Any extra arguments for ...
|
Thanks for your feedback. From my side it looks okay now. If you want me to make additional changes please let me know. |
|
Hello, thank you! Everything looks good to me. Let’s fix the GitHub Action tests, and then we can merge it. 👍
|
Mattes83
changed the title
|
I am not sure about commit message and dco stuff, but the rest should be fixed |
Mattes83
force-pushed
the
capi-support
branch
2 times, most recently
from
a170329 to
397c850
Compare
|
Maybe now... |
This makes ccm compatible with cluster api and cluster api provider proxmox (capmox) Signed-off-by: Matthias Teich <matthias.teich@gdata.de>
|
Thank you! 👍 |
|
Thanks for your help! |
Pull Request
This is currently a work in progress. What do you think of the general approach?
I did not yet find out how to pass the required flag to instances. Do you know how to accomplish this?
What? (description)
This PR aims to add support for clusters managed by cluster api and the capmox infrastructure provider.
Why? (reasoning)
See discussion in #163
Acceptance
Please use the following checklist:
make lint)make unit)