Bug fix/document assembler paragraph properties not copied from template #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and a Tutorial under docs.
Updated DA Multiline content test because the HtmlConverter creates paragraphs rather than inserting soft line breaks.
…nts in a Content select (joins them with a new line). Ran csharpier on all files. Added HtmlAgilityPack to paket references.
…t rather than using paket initially!
Added tests for HTML content (not supported) and non-well formed XHTML. Looking at possibility of replacing XMLReader approach with something closer to HtmlToWmlConverter.
…erties from source template. Re-factored tests for HTML support to check for matching styles in source template and resulting document. Change strong tag definition from "Bold" -> "strong"
This was referenced Jan 2, 2025
…rties-not-copied-from-template
|
Thank you for the fix, released in 2.4.1 |
|
Hi @MalcolmJohnston , Issues is still not fixed in 2.4.1. Below is the sample i tested it. Below the document sample i tested: In 2.3.0, the output of the generated template is like this : But in 2.4.1, you can see the font size and font type remains same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix an issue reported a couple of times since the release of Clippit 2.4.0.
The problem is that the new inline HTML handling had the side effect of NOT copying over any existing paragraph properties that were applied in the template document.
The issue was simple enough to resolve, but I have broken up the tests for the HTML functionality AND made it so that it checks that the paragraph properties in the source template are copied over to the target (the tests work for single and multi line content).
In addition I also spotted that the definition for the strong tag for HTML was incorrect (?) previous definition was "Bold" and I have changed this to "strong".
fixes #90