fix(enmeshed): avoid error when accepting an already active relationship

serlo · Oct 16, 2024 · 6c102f5 · 6c102f5
1 parent 61f19cf
commit 6c102f5
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/packages/server/src/internals/server/enmeshed-middleware.ts b/packages/server/src/internals/server/enmeshed-middleware.ts
@@ -467,14 +467,17 @@ function createEnmeshedWebhookMiddleware(
             ConnectorRelationshipStatus.Rejected as string,
           ].includes(auditLogEntry.newStatus)
         ) {
-          const acceptRelationshipResponse =
-            await client.relationships.acceptRelationship(data.id)
-          if (acceptRelationshipResponse.isError) {
-            handleConnectorError({
-              error: acceptRelationshipResponse.error,
-              message: 'Failed while accepting relationship request',
-            })
+          if (data.status !== (ConnectorRelationshipStatus.Active as string)) {
+            const acceptRelationshipResponse =
+              await client.relationships.acceptRelationship(data.id)
+            if (acceptRelationshipResponse.isError) {
+              handleConnectorError({
+                error: acceptRelationshipResponse.error,
+                message: 'Failed while accepting relationship request',
+              })
+            }
           }
+
           if (!sessionId) {
             await sendWelcomeMessage({ relationship: data, client })
             await sendAttributesChangeRequest({ relationship: data, client })