Merge pull request #1808 from serlo/chore/eslint9

chore: eslint9

esbuild-transformer.js

@@ -18,5 +18,4 @@ async function processAsync(src, filename) {
   }
 }
 
-// eslint-disable-next-line import/no-default-export
 export default { processAsync }

eslint.config.mjs

@@ -0,0 +1,177 @@
+import typescriptEslint from '@typescript-eslint/eslint-plugin'
+import _import from 'eslint-plugin-import'
+import react from 'eslint-plugin-react'
+import { fixupPluginRules } from '@eslint/compat'
+import globals from 'globals'
+import tsParser from '@typescript-eslint/parser'
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
+import js from '@eslint/js'
+import { FlatCompat } from '@eslint/eslintrc'
+
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = path.dirname(__filename)
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+})
+
+export default [
+  {
+    ignores: [
+      'packages/server/src/types.ts',
+      'packages/types/src/index.ts',
+      '**/transform-graphql-jest-28-shim.cjs',
+    ],
+  },
+  ...compat.extends(
+    'eslint:recommended',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/recommended-requiring-type-checking',
+    'plugin:react/recommended',
+    'prettier',
+  ),
+  {
+    plugins: {
+      '@typescript-eslint': typescriptEslint,
+      import: fixupPluginRules(_import),
+      react,
+    },
+
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...globals.jest,
+        ...globals.node,
+      },
+
+      parser: tsParser,
+      ecmaVersion: 5,
+      sourceType: 'commonjs',
+
+      parserOptions: {
+        project: ['tsconfig.json'],
+      },
+    },
+
+    settings: {
+      react: {
+        pragma: 'h',
+        version: '16.8',
+      },
+    },
+
+    rules: {
+      'no-duplicate-imports': 'error',
+      'no-unused-vars': 'off',
+      'no-console': 'error',
+      '@typescript-eslint/ban-ts-comment': 'warn',
+      '@typescript-eslint/consistent-type-definitions': ['error', 'interface'],
+      '@typescript-eslint/explicit-module-boundary-types': 'off',
+      '@typescript-eslint/no-empty-function': 'off',
+      '@typescript-eslint/no-extraneous-class': 'error',
+      '@typescript-eslint/no-parameter-properties': 'off',
+      '@typescript-eslint/no-this-alias': 'warn',
+
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+        },
+      ],
+
+      '@typescript-eslint/no-use-before-define': [
+        'error',
+        {
+          classes: false,
+          functions: false,
+          typedefs: false,
+        },
+      ],
+
+      '@typescript-eslint/no-useless-constructor': 'error',
+      '@typescript-eslint/prefer-ts-expect-error': 'error',
+      'import/export': 'error',
+
+      'import/extensions': [
+        'error',
+        'never',
+        {
+          json: 'always',
+        },
+      ],
+
+      'import/first': 'error',
+      'import/newline-after-import': 'error',
+      'import/no-absolute-path': 'error',
+      'import/no-commonjs': 'error',
+      'import/no-cycle': 'error',
+      'import/no-default-export': 'error',
+      'import/no-deprecated': 'error',
+
+      'import/no-internal-modules': [
+        'error',
+        {
+          allow: [
+            '@pact-foundation/pact/src/dsl/matchers',
+            'msw/node',
+            'msw/lib/**',
+            'mysql2/promise',
+            'io-ts/lib/*',
+            'io-ts-types/lib/*',
+            'fp-ts/lib/*',
+            'ts-jest/utils',
+            '@apollo/server/plugin/disabled',
+            '@apollo/server/express4',
+          ],
+        },
+      ],
+
+      'import/no-mutable-exports': 'error',
+      'import/no-self-import': 'error',
+      'import/no-unassigned-import': 'error',
+
+      'import/no-useless-path-segments': [
+        'error',
+        {
+          noUselessIndex: true,
+        },
+      ],
+
+      'import/order': [
+        'error',
+        {
+          alphabetize: {
+            order: 'asc',
+          },
+
+          groups: [
+            ['builtin', 'external', 'internal'],
+            ['parent', 'sibling', 'index', 'unknown'],
+          ],
+
+          'newlines-between': 'always',
+        },
+      ],
+
+      'react/jsx-boolean-value': 'error',
+      'react/jsx-curly-brace-presence': 'error',
+      'react/prop-types': 'off',
+    },
+  },
+  {
+    files: [
+      '__fixtures__/**/*',
+      '__tests-pacts__/**/*',
+      '__tests__/**/*',
+      '**/jest.setup.ts',
+      '**/jest.setup-pacts.ts',
+    ],
+
+    rules: {
+      '@typescript-eslint/no-non-null-assertion': 'off',
+      'import/no-extraneous-dependencies': 'off',
+    },
+  },
+]

jest.config.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-default-export
 export default {
   modulePaths: ['<rootDir>/packages'],
   moduleNameMapper: {

package.json

@@ -89,6 +89,9 @@
     "graphql": "^16.9.0"
   },
   "devDependencies": {
+    "@eslint/compat": "^1.2.2",
+    "@eslint/eslintrc": "^3.1.0",
+    "@eslint/js": "^9.14.0",
     "@luckycatfactory/esbuild-graphql-loader": "^3.8.1",
     "@tsconfig/node20": "^20.1.4",
     "@types/jest": "^29.5.12",
@@ -98,10 +101,11 @@
     "default-import": "^2.0.1",
     "depcheck": "^1.4.7",
     "esbuild": "^0.24.0",
-    "eslint": "^8.57.0",
+    "eslint": "^9.14.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-import": "^2.30.0",
+    "eslint-plugin-import": "^2.31.0",
     "eslint-plugin-react": "^7.35.2",
+    "globals": "^15.12.0",
     "graphql-tag": "^2.12.6",
     "jest": "^29.7.0",
     "jest-transform-graphql": "^2.1.0",

packages/server/src/schema/authorization/roles.ts

@@ -137,7 +137,6 @@ export function getRolesWithInheritance(initialRoles: Role[] = []): Role[] {
   const allRoles: Role[] = []
   const queue = [...initialRoles]
 
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     const role = queue.pop()
     if (!role) return allRoles

packages/server/src/typings.d.ts

@@ -13,6 +13,5 @@ declare module '*.graphql' {
   import { DocumentNode } from 'graphql'
 
   const node: DocumentNode
-  // eslint-disable-next-line import/no-default-export
   export default node
 }