-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps-dev): bump msw from 1.3.2 to 2.0.3 #1097
Conversation
Bumps [msw](https://github.com/mswjs/msw) from 1.3.2 to 2.0.3. - [Release notes](https://github.com/mswjs/msw/releases) - [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md) - [Commits](mswjs/msw@v1.3.2...v2.0.3) --- updated-dependencies: - dependency-name: msw dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
A newer version of msw exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hejtful!
My comments are mainly small possible improvements. Nothing important which blocks merging. Can all be done in a Follow up PR.
isDefinedBy( | ||
resolver: ResponseResolver< | ||
Record<string, unknown>, | ||
{ payload: Payload<M> } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: type
can be added here
.isDefinedBy((req, res, ctx) => { | ||
const { ids, trashed } = req.body.payload | ||
.isDefinedBy(async ({ request }) => { | ||
const body = (await request.json()) as { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const body = (await request.json()) as { | |
const body = (await request.json()) |
Bumps msw from 1.3.2 to 2.0.3.
Release notes
Sourced from msw's releases.
... (truncated)
Commits
461a188
chore(release): v2.0.3a0ec8be
fix: correctly check "undefined" as response body type (#1824)66fb437
fix(Safari): send explicit null response bodies (#1833)008a8c6
chore(smoke): support workflow_run and workflow_dispatch057e515
chore(smoke): use manual runs only5112765
chore(smoke): support workflow_dispatch009e8fa
chore: add "smoke-test/examples" workflow (#1825)dff7fac
chore(release): v2.0.22ead392
fix: output a single formatted message to console (#1820)a179b68
fix: prevent one-time handlers from incorrectly marking themselves as used (#...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)